Merged
Conversation
Co-authored-by: theo <[email protected]> Amp-Thread-ID: https://ampcode.com/threads/T-019c37c7-b4b3-77e8-8d14-010450883a97 Co-authored-by: Amp <[email protected]>
gakonst
requested review from
DaniPopes,
grandizzy,
klkvr,
mattsse,
onbjerg and
zerosnacks
as code owners
mattsse
approved these changes
Feb 7, 2026
Co-authored-by: theo <[email protected]> Amp-Thread-ID: https://ampcode.com/threads/T-019c37c7-b4b3-77e8-8d14-010450883a97 Co-authored-by: Amp <[email protected]>
gakonst
added a commit
to paradigmxyz/reth
that referenced
this pull request
Feb 12, 2026
Replace the local InMemorySize trait definition with a re-export from alloy_consensus. The trait and all shared impls now live upstream in alloy (alloy-rs/alloy#3656), and the op type impls live in op-alloy (alloy-rs/op-alloy#624). Prompted by: mattsse Amp-Thread-ID: https://ampcode.com/threads/T-019c5388-ba74-7186-9892-926539efe2c1 Co-authored-by: Amp <[email protected]>
github-merge-queue bot
pushed a commit
to alloy-rs/op-alloy
that referenced
this pull request
Feb 12, 2026
## Summary Implement `alloy_consensus::InMemorySize` trait for op consensus types. ## Motivation Part of a multi-repo effort to move the `InMemorySize` trait from reth into alloy (done in [alloy#3656](alloy-rs/alloy#3656)). With the trait now in alloy-consensus, reth can re-export it instead of defining it locally. However, due to the orphan rule, the op type impls must live in op-alloy. ## Changes - Bump `alloy-consensus` minimum to 1.6.2 (which includes `InMemorySize`) - Add `InMemorySize` impls for: `OpTxType`, `TxDeposit`, `OpDepositReceipt`, `OpReceipt`, `OpTypedTransaction`, `OpPooledTransaction`, `OpTxEnvelope` ## Testing ``` cargo check -p op-alloy-consensus --all-features cargo test -p op-alloy-consensus ``` Prompted by: mattsse --------- Co-authored-by: Amp <[email protected]>
refcell
pushed a commit
to base/base
that referenced
this pull request
Feb 18, 2026
## Summary Implement `alloy_consensus::InMemorySize` trait for op consensus types. ## Motivation Part of a multi-repo effort to move the `InMemorySize` trait from reth into alloy (done in [alloy#3656](alloy-rs/alloy#3656)). With the trait now in alloy-consensus, reth can re-export it instead of defining it locally. However, due to the orphan rule, the op type impls must live in op-alloy. ## Changes - Bump `alloy-consensus` minimum to 1.6.2 (which includes `InMemorySize`) - Add `InMemorySize` impls for: `OpTxType`, `TxDeposit`, `OpDepositReceipt`, `OpReceipt`, `OpTypedTransaction`, `OpPooledTransaction`, `OpTxEnvelope` ## Testing ``` cargo check -p op-alloy-consensus --all-features cargo test -p op-alloy-consensus ``` Prompted by: mattsse --------- Co-authored-by: Amp <[email protected]>
refcell
pushed a commit
to base/base
that referenced
this pull request
Feb 18, 2026
## Summary Implement `alloy_consensus::InMemorySize` trait for op consensus types. ## Motivation Part of a multi-repo effort to move the `InMemorySize` trait from reth into alloy (done in [alloy#3656](alloy-rs/alloy#3656)). With the trait now in alloy-consensus, reth can re-export it instead of defining it locally. However, due to the orphan rule, the op type impls must live in op-alloy. ## Changes - Bump `alloy-consensus` minimum to 1.6.2 (which includes `InMemorySize`) - Add `InMemorySize` impls for: `OpTxType`, `TxDeposit`, `OpDepositReceipt`, `OpReceipt`, `OpTypedTransaction`, `OpPooledTransaction`, `OpTxEnvelope` ## Testing ``` cargo check -p op-alloy-consensus --all-features cargo test -p op-alloy-consensus ``` Prompted by: mattsse --------- Co-authored-by: Amp <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the
InMemorySizetrait toalloy-consensusfor calculating heuristic in-memory size of consensus types.Motivation
Split out from #3649. This is part of a multi-repo effort to remove
op-alloy-*dependencies from core reth crates. Moving trait definitions into alloy allows op-alloy to implement them natively.Changes
InMemorySizetrait incrates/consensus/src/size.rsHeader,TxLegacy,TxEip2930,TxEip1559,TxEip7702,TxEip4844,Receipt,Block,BlockBody, etc.alloy_consensus::InMemorySizeTesting