fix(rpc-types): don't return EIP-4844 type for max_fee_per_blob_gas alone#3651
Merged
fix(rpc-types): don't return EIP-4844 type for max_fee_per_blob_gas alone#3651
Conversation
…lone When only max_fee_per_blob_gas is set without blob_versioned_hashes or sidecar, the transaction should not be classified as EIP-4844. This matches go-ethereum behavior where ToTransaction() only returns BlobTxType if BlobHashes is set: https://github.com/ethereum/go-ethereum/blob/master/internal/ethapi/transaction_args.go The issue was causing eth_simulateV1 to fail with 'Transaction is not buildable' when processing transactions with just maxFeePerBlobGas set, while other clients (geth, besu, nethermind, erigon) handled it correctly. Changes: - Add has_eip4844_blob_data() method that only checks for sidecar or blob_versioned_hashes (not just max_fee_per_blob_gas) - Update preferred_type() and minimal_tx_type() to use the new method - Update documentation to clarify the behavior Fixes: paradigmxyz/reth#21809 Amp-Thread-ID: https://ampcode.com/threads/T-019c32bb-6721-779b-ad46-b1cbcace664a Co-authored-by: Amp <[email protected]>
gakonst
requested review from
DaniPopes,
grandizzy,
klkvr,
mattsse,
onbjerg and
zerosnacks
as code owners
gakonst
added a commit
to paradigmxyz/reth
that referenced
this pull request
Feb 6, 2026
…data Adds an e2e test that verifies eth_simulateV1 correctly handles transactions with maxFeePerBlobGas set but no blob_versioned_hashes or sidecar. The transaction should be treated as EIP-1559. This test reproduces the issue where reth returned 'Transaction is not buildable' while geth, besu, nethermind, and erigon all succeeded. The root cause is fixed in alloy-rs/alloy#3651. Closes #21809 Amp-Thread-ID: https://ampcode.com/threads/T-019c32bb-6721-779b-ad46-b1cbcace664a Co-authored-by: Amp <[email protected]>
mattsse
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When only
max_fee_per_blob_gasis set withoutblob_versioned_hashesor sidecar, the transaction should not be classified as EIP-4844.This matches go-ethereum behavior where
ToTransaction()only returnsBlobTxTypeifBlobHashesis set:https://github.com/ethereum/go-ethereum/blob/master/internal/ethapi/transaction_args.go#L377-L379
The issue was causing
eth_simulateV1to fail in reth withTransaction is not buildablewhen processing transactions with justmaxFeePerBlobGasset, while other clients (geth, besu, nethermind, erigon) handled it correctly.Changes:
has_eip4844_blob_data()method that only checks for sidecar orblob_versioned_hashes(not justmax_fee_per_blob_gas)preferred_type()andminimal_tx_type()to use the new methodFixes: paradigmxyz/reth#21809