perf(provider): use get_header instead of get_block in get_block_number_by_id#3640
Merged
mattsse merged 2 commits intoalloy-rs:mainfrom Feb 5, 2026
Merged
perf(provider): use get_header instead of get_block in get_block_number_by_id#3640mattsse merged 2 commits intoalloy-rs:mainfrom
mattsse merged 2 commits intoalloy-rs:mainfrom
Conversation
snazzysam933
requested review from
DaniPopes,
grandizzy,
klkvr,
mattsse,
onbjerg and
zerosnacks
as code owners
Contributor
Author
|
Updated to use fallback: try get_header first, fall back to get_block if not supported. Turns out |
mattsse
reviewed
Feb 5, 2026
Member
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
this is problematic, because not all clients/providers have this
mattsse
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We only need the block number here, no reason to fetch the entire block with all its transactions. Now that get_header exists, let's use it.