fix(node-bindings): kill anvil child on timeout#3635
Merged
mattsse merged 1 commit intoalloy-rs:mainfrom Feb 3, 2026
Merged
Conversation
SashaMalysehko
requested review from
DaniPopes,
grandizzy,
klkvr,
mattsse,
onbjerg and
zerosnacks
as code owners
mattsse
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Previously,
Anvil::try_spawnreturnedNodeError::Timeoutwithout killing the spawned child process. This left stray Anvil instances running in the background whenever startup timed out, unlike the Geth and Reth implementations which explicitly kill their child processes on timeout.Solution
Add a kill of the Anvil child process when try_spawn times out, aligning its behavior with Geth and Reth and preventing leaked node processes on startup timeout.
PR Checklist