fix: reduce test flakiness for node-bindings and network tests#3632
Merged
fix: reduce test flakiness for node-bindings and network tests#3632
Conversation
mattsse
requested review from
DaniPopes,
klkvr,
onbjerg and
zerosnacks
as code owners
DaniPopes
reviewed
Feb 1, 2026
- Handle transport errors (502, timeouts) in test_pending_block_deser - Run alloy-node-bindings tests serially via nextest to avoid resource contention - Add retries with exponential backoff for node-bindings tests Co-authored-by: Amp <[email protected]> Amp-Thread-ID: https://ampcode.com/threads/T-019c1aa1-482f-774a-be9a-57cb99c44f08
mattsse
force-pushed
the
fix/flaky-tests
branch
from
9d9ea3b to
7ea83d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reduces CI flakiness by:
Handling transport errors in
test_pending_block_deser- The test now skips on any transport error (502, timeouts, connection failures) rather than just "no response" errors.Running
alloy-node-bindingstests serially - Uses nextest'sthreads-required = "num-cpus"to prevent resource contention between heavy e2e tests.Adding retries for node-bindings tests - Exponential backoff with 3 retries for transient failures.
Fixes flaky CI failures like: https://github.com/alloy-rs/alloy/actions/runs/21563960416/job/62143557052