Merged
Conversation
hecmas
requested review from
DaniPopes,
grandizzy,
klkvr,
mattsse,
onbjerg and
zerosnacks
as code owners
Contributor
|
This makes sense to me! Would be useful to clean up https://github.com/paradigmxyz/reth/blob/0b5f79e8c9226ee66c96eb35d2a5f4408e8c48ac/crates/stateless/src/recover_block.rs#L79 |
mattsse
reviewed
Jan 26, 2026
crates/consensus/src/crypto.rs
Outdated
Comment on lines
55
to
57
| /// Serialized uncompressed public key | ||
| #[derive(Debug, Clone)] | ||
| pub struct UncompressedPublicKey(pub [u8; 65]); |
Member
There was a problem hiding this comment.
do we even need this type?
rn the called would need to copy the 64bytes into this for
pubkey: &UncompressedPublicKey,
Contributor
There was a problem hiding this comment.
I think we can make it a type alias or use [u8;65] -- we needed it in reth-stateless for serialization reasons though it should be easy to convert in that crate
Contributor
Author
There was a problem hiding this comment.
Agree with @kevaundray, I think a type alias would be the cleanest solution as for now.
mattsse
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Following #2634, I've added a method for being able to inject an ECDSA verification.
Solution
PR Checklist