fix(rpc-types-eth): add serde alias for MovePrecompileToAddress#3589
Merged
onbjerg merged 1 commit intoalloy-rs:mainfrom Jan 25, 2026
Merged
Conversation
Accept both camelCase (movePrecompileToAddress) and PascalCase (MovePrecompileToAddress) for backwards compatibility with test fixtures that use the PascalCase variant. Amp-Thread-ID: https://ampcode.com/threads/T-019bf5ac-dd59-76c0-8ba8-8739e84b6a33 Co-authored-by: Amp <[email protected]>
mattsse
requested review from
DaniPopes,
grandizzy,
klkvr,
onbjerg and
zerosnacks
as code owners
onbjerg
approved these changes
Jan 25, 2026
Rimeeeeee
added a commit
to Soubhik-10/alloy
that referenced
this pull request
Jan 26, 2026
…ss (alloy-rs#3589)" This reverts commit 615f4c6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Accept both camelCase (
movePrecompileToAddress) and PascalCase (MovePrecompileToAddress) for themove_precompile_tofield inAccountOverride.Context
The hive test fixtures at
ethereum/execution-apisuse PascalCaseMovePrecompileToAddressfor this field, but the OpenRPC spec and geth use camelCasemovePrecompileToAddress.Adding a serde alias allows accepting both variants for backwards compatibility, fixing the parsing error:
Test
Fixes hive tests:
eth_simulateV1/ethSimulate-move-ecrecover-and-call-old-and-neweth_simulateV1/ethSimulate-move-ecrecover-and-call