feat(provider): add new_payload_v4_requests accepting RequestsOrHash#3556
Merged
feat(provider): add new_payload_v4_requests accepting RequestsOrHash#3556
Conversation
mattsse
requested review from
DaniPopes,
grandizzy,
klkvr,
onbjerg and
zerosnacks
as code owners
mattsse
force-pushed
the
matt/new-payload-v4-requests
branch
from
bd85027 to
4cccbd5
Compare
- Add From<Vec<Bytes>> impl for Requests (zero-cost) - Add Requests::from_requests for iterator conversion - Add new_payload_v4_requests variant that accepts RequestsOrHash - Keep original new_payload_v4 unchanged for backwards compatibility
mattsse
force-pushed
the
matt/new-payload-v4-requests
branch
from
4cccbd5 to
b3c3e4c
Compare
gakonst
approved these changes
Jan 20, 2026
Member
gakonst
left a comment
gakonst
left a comment
There was a problem hiding this comment.
LGTM - clean addition that mirrors the v5 API pattern. CI green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
new_payload_v4_requestsmethod that acceptsRequestsOrHashinstead ofVec<Bytes>, allowing callers to pass either the full requests or just a precomputed hash.Changes
From<Vec<Bytes>>impl forRequests(zero-cost, no allocation)Requests::from_requestsfor converting from iterators ofInto<Bytes>new_payload_v4_requestsvariant that acceptsRequestsOrHashnew_payload_v4unchanged for backwards compatibilityThis mirrors the approach used for
new_payload_v5which already acceptsRequestsOrHash.