docs(signer): fix sign_dynamic_typed_data documentation#3545
Merged
mattsse merged 4 commits intoalloy-rs:mainfrom Jan 20, 2026
Merged
docs(signer): fix sign_dynamic_typed_data documentation#3545mattsse merged 4 commits intoalloy-rs:mainfrom
mattsse merged 4 commits intoalloy-rs:mainfrom
Conversation
forkfury
requested review from
DaniPopes,
grandizzy,
klkvr,
mattsse,
onbjerg and
zerosnacks
as code owners
mattsse
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrected misleading documentation for sign_dynamic_typed_data methods.
The previous comment incorrectly stated these methods work "for Signers that
are not dynamically sized", when in fact they work with unsized Signers
(trait objects). Updated both async and sync variants to clarify that they
work with trait objects like Box.