refactor(serde): reuse deserialize_into in OtherFields::deserialize_as#3533
Merged
onbjerg merged 1 commit intoalloy-rs:mainfrom Jan 16, 2026
Merged
refactor(serde): reuse deserialize_into in OtherFields::deserialize_as#3533onbjerg merged 1 commit intoalloy-rs:mainfrom
onbjerg merged 1 commit intoalloy-rs:mainfrom
Conversation
vtjl10
requested review from
DaniPopes,
grandizzy,
klkvr,
mattsse,
onbjerg and
zerosnacks
as code owners
onbjerg
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OtherFields::deserialize_asduplicated the conversion logic already implemented indeserialize_into, which increases the chance of the two methods drifting over time.Make
deserialize_asdelegate todeserialize_into(self.clone().deserialize_into()), keeping the API and behavior unchanged while maintaining a single source of truth.