feat(rpc-client): allow setting terminal error codes on pollers#3421
Merged
mattsse merged 2 commits intoalloy-rs:mainfrom Jan 22, 2026
Merged
feat(rpc-client): allow setting terminal error codes on pollers#3421mattsse merged 2 commits intoalloy-rs:mainfrom
mattsse merged 2 commits intoalloy-rs:mainfrom
Conversation
Co-authored-by: nadtech-hub <[email protected]>
siosw
requested review from
DaniPopes,
grandizzy,
klkvr,
mattsse,
onbjerg and
zerosnacks
as code owners
Contributor
Author
|
@mattsse just gently pinging here if this is smth you'd still be looking to get in |
Member
|
sorry this got lost over the new years -.- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#2826
Solution
continuation of #3182
allows terminal error codes to be set on the
Pollerthat will cause it to terminate.if no codes are set we use the existing logic to use the error message as a fallback
PR Checklist