feat: added ExecutionPayloadV4 and engine_newPayloadV5,engine_getPayloadV6#3330
Open
Rimeeeeee wants to merge 30 commits intoalloy-rs:mainfrom
Open
feat: added ExecutionPayloadV4 and engine_newPayloadV5,engine_getPayloadV6#3330Rimeeeeee wants to merge 30 commits intoalloy-rs:mainfrom
Rimeeeeee wants to merge 30 commits intoalloy-rs:mainfrom
Conversation
Rimeeeeee
requested review from
DaniPopes,
grandizzy,
klkvr,
mattsse,
onbjerg and
zerosnacks
as code owners
mattsse
requested changes
Dec 30, 2025
Member
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
great stuff
left some questions
could you perhaps rebase this one and also prepare a reth pr with alloy patches to this branch with activated amsterdam feature?
then we can start integrating this to main, basically splitting up the bal-devnet-1 branch into smaller chunks
| /// Represents all possible payload versions. | ||
| #[derive(Debug, Serialize)] | ||
| #[serde(untagged)] | ||
| #[cfg(not(feature = "amsterdam"))] |
Member
There was a problem hiding this comment.
instead of feature gating the type, can we instead feature gate the variant instead?
Comment on lines
102
to
103
| #[cfg(not(feature = "amsterdam"))] | ||
| impl AnyHeader { |
Member
There was a problem hiding this comment.
do we need this feature gated impl or can we instead feature gate the the access_list_hash usage instead?
This was referenced Jan 20, 2026
mattsse
added a commit
that referenced
this pull request
Jan 21, 2026
Adds BeaconExecutionPayloadV4 struct and beacon_payload_v4 serde helper module to support the Beacon API representation of ExecutionPayloadV4. This complements the ExecutionPayloadV4 type added in #3330. See: #3330 Co-authored-by: Rimeeeeee <[email protected]> Co-authored-by: Soubhik-10 <[email protected]>
mattsse
added a commit
that referenced
this pull request
Jan 21, 2026
Adds BeaconExecutionPayloadV4 struct and beacon_payload_v4 serde helper module to support the Beacon API representation of ExecutionPayloadV4. This complements the ExecutionPayloadV4 type added in #3330. See: #3330 Co-authored-by: Rimeeeeee <[email protected]> Co-authored-by: Soubhik-10 <[email protected]>
mattsse
added a commit
that referenced
this pull request
Jan 21, 2026
Adds BeaconExecutionPayloadV4 struct and beacon_payload_v4 serde helper module to support the Beacon API representation of ExecutionPayloadV4. This complements the ExecutionPayloadV4 type added in #3330. See: #3330 Co-authored-by: Rimeeeeee <[email protected]> Co-authored-by: Soubhik-10 <[email protected]>
mattsse
added a commit
that referenced
this pull request
Jan 21, 2026
Adds BeaconExecutionPayloadV4 struct and beacon_payload_v4 serde helper module to support the Beacon API representation of ExecutionPayloadV4. This complements the ExecutionPayloadV4 type added in #3330. See: #3330 Co-authored-by: Rimeeeeee <[email protected]> Co-authored-by: Soubhik-10 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
ExecutionPayloadV4andengine_newPayloadV5,engine_getPayloadV6.ref
cc: @mattsse