fix(contract): propagate TransportError when all eth_call overrides fail#3316
Merged
mattsse merged 1 commit intoalloy-rs:mainfrom Jan 22, 2026
Merged
Conversation
phrwlk
requested review from
DaniPopes,
grandizzy,
klkvr,
mattsse,
onbjerg and
zerosnacks
as code owners
mattsse
force-pushed
the
fix/storage-slot-finder-error-propagation
branch
from
bc7d9ff to
e394610
Compare
mattsse
approved these changes
Jan 22, 2026
When all eth_call attempts with state overrides fail (e.g., RPC down, auth errors), StorageSlotFinder::find_slot now propagates the first error instead of silently returning Ok(None). Changes: - Track any_call_succeeded and first_call_err - Use get_or_insert to capture first error (more deterministic) - Propagate error only when no call succeeded
mattsse
force-pushed
the
fix/storage-slot-finder-error-propagation
branch
from
e394610 to
cc275e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change ensures StorageSlotFinder::find_slot does not silently return Ok(None) when every eth_call with state overrides fails. We keep iterating on per-slot failures to tolerate intermittent RPC issues, but if no call succeeds we now return the last TransportError. This aligns behavior with the method’s documentation and avoids masking provider configurations that don’t support state overrides. Decode errors remain skipped as before since the API returns only TransportError