feat: error code for dropped filters#3182
Open
nadtech-hub wants to merge 2 commits intoalloy-rs:mainfrom
Open
Conversation
nadtech-hub
requested review from
DaniPopes,
grandizzy,
klkvr,
mattsse,
onbjerg and
zerosnacks
as code owners
nadtech-hub
changed the title
Contributor
|
hey @nadtech-hub thanks for the PR, this isn't quite what I was going for when writing the issue, if resp.message.contains("filter not found") || self.terminal_error_codes.contains(resp.code) {
// stop the poller
}where the list of error codes is something the user of the poller can set |
Contributor
Author
so you need certain RPC error codes. @siosw see if changes are sufficient now |
Signed-off-by: Aliaksei Misiukevich <[email protected]>
Signed-off-by: Aliaksei Misiukevich <[email protected]>
nadtech-hub
force-pushed
the
nadtech/poller_error_codes
branch
from
7701fb7 to
5705843
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should resolve #2826