Conversation
DaniPopes
requested changes
Aug 28, 2023
README.md
Outdated
| feature is enabled, compilation for the `getrandom` crate will fail. This is | ||
| expected: see [their documentation][getrandom] for more details. | ||
|
|
||
| To fix this, either disable the `"getrandom"` feature on `alloy-core` or add |
Member
There was a problem hiding this comment.
outdated, probably just remove this paragraph
Member
Author
There was a problem hiding this comment.
ah can you also remove from core?
DaniPopes
approved these changes
Aug 28, 2023
Member
DaniPopes
left a comment
DaniPopes
left a comment
There was a problem hiding this comment.
LGTM, can resolve CI in a follow up
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.