chore: avoid panic in HTTP transport: return error instead of expect#2862
Merged
mattsse merged 1 commit intoalloy-rs:mainfrom Sep 11, 2025
Merged
chore: avoid panic in HTTP transport: return error instead of expect#2862mattsse merged 1 commit intoalloy-rs:mainfrom
mattsse merged 1 commit intoalloy-rs:mainfrom
Conversation
prestoalvarez
requested review from
DaniPopes,
klkvr,
mattsse and
yash-atreya
as code owners
mattsse
changed the title
mattsse
approved these changes
Sep 11, 2025
nadtech-hub
added a commit
to nadtech-hub/alloy
that referenced
this pull request
Nov 12, 2025
Signed-off-by: Aliaksei Misiukevich <[email protected]>
nadtech-hub
added a commit
to nadtech-hub/alloy
that referenced
this pull request
Nov 16, 2025
Signed-off-by: Aliaksei Misiukevich <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
expect("request parts are invalid")withmap_err(TransportErrorKind::custom)?when building the Hyper request.TransportErrorinstead.