Conversation
The post-incdec operator is particularly broken in the old code generator. We make no attempt to fix it here, since it is not worth trying to preserve old behavior in this case. The new parser avoids calling emit_userop since it is complicated and inefficient. New tests for this will fail on the current parser, so they are disabled. Unfortunately, the new code generation patterns wildly trip up the optimizer. The optimizer has many patterns that result in incorrect replacements (for example, exchanging a move+push for a push). Since the long term plan is to remove the optimizer and simply emit better code, we now disable the optimizer for expressions using the new parser.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The post-incdec operator is particularly broken in the old code
generator. We make no attempt to fix it here, since it is not worth
trying to preserve old behavior in this case. The new parser avoids
calling emit_userop since it is complicated and inefficient.
New tests for this will fail on the current parser, so they are
disabled.
Unfortunately, the new code generation patterns wildly trip up the
optimizer. The optimizer has many patterns that result in incorrect
replacements (for example, exchanging a move+push for a push). Since
the long term plan is to remove the optimizer and simply emit better
code, we now disable the optimizer for expressions using the new parser.