Conversation
…embly. The two-pass system in the compiler is able to roughly guess which functions are not used, but it's a poor guess. Stocks called by other stocks, including recursive functions, all get compiled in. We can fix this by traversing the call graph to determine the actual live set. Note, the assembler now skips functions with uDEFINED but not uPUBLIC. uDEFINED is cleared by delete_symbols, so it looks like a pointless check. This patch shaves about 10% off some .smx files sampled from the SourceMod tree. Bug: issue #358 Test: manual test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.