Fix incorrect reported file in error message when missing a required semicolon.#331
Merged
Fix incorrect reported file in error message when missing a required semicolon.#331
Conversation
asherkin
approved these changes
May 7, 2019
Member
|
Are you sure the test is correct? You're including a nonexistent file. Maybe I'm not understanding the bug here. |
Contributor
Author
|
I'm including an almost empty file. Try the test against master (i.e. without this PR) and the error reported will be in the empty file. Almost empty because apparently if you try to include an actual 0-byte file, spcomp will error. |
Member
I think it got renamed at one point, the filename here does indeed seem wrong. |
Contributor
Author
|
I did rename it, but the test still passed because the check was lax. Fixed, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would only happen with
#pragma semicolon 1if a semicolon was missing after some other file was included.Without the change, the error reported for the test case would be in the empty include (though with the correct line number).