Skip to content

Fix a HEA leak when using break in nested scopes.#207

Merged
dvander merged 1 commit intomasterfrom
fix-leak
May 4, 2018
Merged

Fix a HEA leak when using break in nested scopes.#207
dvander merged 1 commit intomasterfrom
fix-leak

Conversation

@dvander
Copy link
Member

@dvander dvander commented May 4, 2018

Ancient bug - looks like it's a carryover from AMX Mod X.

The following script will misalign the HEA stack:

native void printnum(int n);

public main() {
  while (true) {
    for (int i = 1; i < 10; i++) {
      char[] egg = new char[i];
      if (i % 2 == 0) {
         char[] yam = new char[i + 3];
         break;
      } else {
         char[] yam = new char[i + 3];
         continue;
      }
    }
  }
}

@dvander
Copy link
Member Author

dvander commented May 4, 2018

Not from AMX Mod X, but was improperly fixed 12 years ago: alliedmodders/sourcemod@4d44a1d

@dvander dvander merged commit 003e9fd into master May 4, 2018
@dvander dvander deleted the fix-leak branch May 4, 2018 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant