Add Shield and Bumpmine to cstrike.inc#991
Merged
Headline merged 2 commits intoalliedmodders:masterfrom May 24, 2019
Merged
Conversation
Shield was added after P250 and Scar20 ( SteamDatabase/GameTracking-CS2@eb493d0#diff-61078bd2bc26e33766f09f0c5b9ac935R22422 )
|
May be better to do smth like that ? f5ad5af |
Drifter321
requested changes
May 24, 2019
Member
Drifter321
left a comment
Drifter321
left a comment
There was a problem hiding this comment.
Bumpmine is fine. Shield should not be added to the enum as it would break id's below it. The extension function GetWeaponIdFromDefIdx should be updated to have the respective SMCSWeapon_NONE be SMCSWeapon_SHIELD
Remove CSWeapon_SHIELD from CSWeaponID
Contributor
Author
|
👌🏻 |
Drifter321
approved these changes
May 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shield was added between P250 and Scar20 ( SteamDatabase/GameTracking-CS2@eb493d0#diff-61078bd2bc26e33766f09f0c5b9ac935R22422 )