sm_cookies now display a number before the cookie (without arguments) similar to sm_help#977
sm_cookies now display a number before the cookie (without arguments) similar to sm_help#977KyleSanderson merged 8 commits intoalliedmodders:masterfrom eyal282:master
Conversation
KyleSanderson
left a comment
There was a problem hiding this comment.
Good idea, we have this pattern elsewhere. While an internal implementation detail this is a good addition. Thank you very much.
|
I think I solved all issues, sorry for my lack of scripting skills when it comes to making it look sane, I come from AmxModX and learning a to format in a generally accepted way can be sometimes difficult to me. |
|
I should mention I have not a slight clue about anything related to the "Some checks haven't completed yet" of the "continuous-integration" error |
|
Anyways, are you okay with my changes or there is anything I forgot / new changes needed? |
|
Changed the while's formatting according to advice in sourcemod's discord channel. |
plugins/clientprefs.sp
Outdated
| int count = 1; | ||
|
|
||
| while | ||
| (ReadCookieIterator( |
There was a problem hiding this comment.
Some how you keep making this look even worse...
There was a problem hiding this comment.
Can you give your own idea on how to fix how it looks?
Headline
left a comment
There was a problem hiding this comment.
dismissing the rest to peers
[001] cookieName - Cookie's description
[002] anotherCookieName - Another Cookie's description.
This is extremely effective when the description reaches a new line.
On top of that, I also made sm_cookies show the cookie's description rather than just the value in a manner similar to writing the name of a cvar.
THIS PULL REQUEST REQUIRES SOME DEGREE OF TESTING. I hope someone will have the spare time to test out everything possible and give some input on the change.