Conversation
Headline
added
Bug
asherkin
approved these changes
Jan 13, 2019
Member
asherkin
left a comment
asherkin
left a comment
There was a problem hiding this comment.
This seems sane.
I thought about it quite a bit earlier, but there is no pattern where the existing could could have worked, is there? So this doesn't risk breaking anyone?
Member
|
This is a regression... You should not be able to slam Next until this overflows... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this patch, we'd check OOB before incrementing which makes no sense. We'll increment always this time, and change our OOB check to account for that.
Prior versions of the FrameIterator never worked, so we should probably cherry-pick this to 1.9