Handle NULLs in SDKCall string return (Fixes #874)#906
Merged
Conversation
`SDKCall` has existing semantics that a `-1` retval indicates null, so use that and writes an empty string to the buffer. Consumers can tell the difference between `""` and `NULL` by checking if the return value is `0` or `-1`.
psychonic
approved these changes
Oct 10, 2018
Headline
reviewed
Oct 10, 2018
Member
Headline
left a comment
Headline
left a comment
There was a problem hiding this comment.
I’d prefer to be explicit about casts and avoid c-style
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDKCallhas existing semantics that a-1retval indicates null, so use that and write an empty string to the buffer.Consumers can tell the difference between
""andNULLby checking if the return value is0or-1.