Conversation
Member
Author
|
Rational behind semicolon removal: they don't do much except make C/C++ programmers feel at home. There's nothing real bad about that and the behavior in this patch should match what would be natural in a C++ environment. But Dissuading them in official style is sort of predicated on an SP-aware lint tool though, which does not exist yet. |
Member
|
🚢 |
dvander
added a commit
that referenced
this pull request
Jul 13, 2014
Fix and formalize newline and semicolon behavior in methodmaps. (bug 6175)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch formalizes line endings a bit for methodmaps. The new rules are:
The way this is implemented is via a new
peek_same_lineconstruct in the lexer. This will return either end-of-line, or a token ID that is not on the same line. The lexer now attaches line/col information into token data to make this work.I am gunning to remove
#pragma semicolonin a future version of SourcePawn, and to revise official style to dissuade them. If we can get there, this patch will be mostly pointless, but for now I've tried to match what other Pawn constructs do. Getting the correct newline behavior at least is a step forward.