Conversation
Headline
reviewed
Aug 19, 2018
Member
Headline
left a comment
Headline
left a comment
There was a problem hiding this comment.
If my understanding is correct, the removal of that flag doesn't even change the behavior since sm_map menu points to default in the configurations correct?
Member
Author
|
These 2 currently have a separate file specified: sourcemod/configs/maplists.cfg Lines 30 to 40 in 17700e4 The problem is that upon removal of that configuration (or if that file can't be loaded), they fall back to loading all the maps rather than the documented behaviour of try "default" then "mapcyclefile". There is indeed no out-of-the-box behaviour change from this PR though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These two base plugins are using the
MAPLIST_FLAG_NO_DEFAULTwhen they shouldn't, which causes much user (and SM developer) confusion as it is completely counter to the documentation.Raised by @DoctorOcsid on Discord.