Skip to content

Allow any returns in native callbacks#857

Merged
Headline merged 1 commit intomasterfrom
native-ret-any
Jul 26, 2018
Merged

Allow any returns in native callbacks#857
Headline merged 1 commit intomasterfrom
native-ret-any

Conversation

@Headline
Copy link
Member

@Headline Headline commented Jul 24, 2018

Native callbacks currently require plugin authors to retag their returns to an int, but by adding any as another acceptable prototype we allow them to return without needing to retag.

public any Native_Something(Handle plugin, int numParams)
{
    float val =5.0;
    return val; // no tag mismatch
}

Thanks asherkin for bringing this change to light

@Headline Headline requested a review from asherkin July 24, 2018 21:04
@KyleSanderson
Copy link
Member

KyleSanderson commented Jul 25, 2018

I guess we still need int in there for old code? is this correct?

@Headline
Copy link
Member Author

Headline commented Jul 25, 2018

The typeset has the older int prototype, this shouldn’t break anything older. Many of our built-in plugins still use the int counterpart and they compile

@KyleSanderson
Copy link
Member

KyleSanderson commented Jul 25, 2018

Why not just change it to any then? Does this give some micro-optimization?

@Headline
Copy link
Member Author

Headline commented Jul 25, 2018

@KyleSanderson if we changed int to any and kept the typedef, then every callback would have to be rewritten. While int, float, char can coherse to any, they're still different types and the compiler errors out w/ prototype mismatch. We need that typeset(funcenum) for this change to be possible.

@Headline Headline merged commit 11abe77 into master Jul 26, 2018
@Headline Headline deleted the native-ret-any branch July 26, 2018 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asherkin asherkin asherkin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Headline @KyleSanderson @asherkin