Conversation
dvander
added a commit
that referenced
this pull request
Jul 8, 2014
Begin locking down function types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of the recent type system overhaul, automatic coercion of Functions to non-functions (and vice versa) became a compile-time error. They no longer flow into "any" or variadic lists. However, it's still possible to re-tag functions, for example,
Function:-1or_:OnPluginStart.This patch deprecates such forced coercions with a warning. This set off some problems in our includes, so I updated them to use
INVALID_FUNCTIONwhere appropriate.To get inline functions or lambdas working, we will have to make this a full-stop error. But for now it's okay to test the waters.