Fix "Exception reported: Client 12 is not in game"#723
Merged
KyleSanderson merged 3 commits intoalliedmodders:masterfrom Jul 12, 2018
komashchenko:master
Merged
Fix "Exception reported: Client 12 is not in game"#723KyleSanderson merged 3 commits intoalliedmodders:masterfrom komashchenko:master
KyleSanderson merged 3 commits intoalliedmodders:masterfrom
komashchenko:master
Conversation
WildCard65
reviewed
Nov 19, 2017
plugins/adminhelp.sp
Outdated
|
|
||
| public Action HelpCmd(int client, int args) | ||
| { | ||
| if(!IsClientInGame(client)) return Plugin_Handled; |
Contributor
There was a problem hiding this comment.
Nit pick: Please make the style match the rest of the file, see line 78-81(after additions).
Member
There was a problem hiding this comment.
This is so close to being right, but breaks console support and moves the error (reliably) there as rcon/console is 0.
KyleSanderson
requested changes
Nov 21, 2017
plugins/adminhelp.sp
Outdated
|
|
||
| public Action HelpCmd(int client, int args) | ||
| { | ||
| if(!IsClientInGame(client)) return Plugin_Handled; |
Member
There was a problem hiding this comment.
This is so close to being right, but breaks console support and moves the error (reliably) there as rcon/console is 0.
TiBarification
approved these changes
Jan 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
L 11/19/2017 - 16:37:02: [SM] Exception reported: Client 12 is not in game
L 11/19/2017 - 16:37:02: [SM] Blaming: adminhelp.smx
L 11/19/2017 - 16:37:02: [SM] Call stack trace:
L 11/19/2017 - 16:37:02: [SM] [0] PrintToConsole
L 11/19/2017 - 16:37:02: [SM] [1] Line 105, /home/builds/sourcemod/linux-1.9/build/plugins/adminhelp.sp::HelpCmd