Added more translation to basechat#674
Added more translation to basechat#674KyleSanderson merged 6 commits intoalliedmodders:masterfrom TiBarification:phrases_fix
Conversation
Also fixed colors, because it didn't work without `\x01` at begin of string.
|
\x01 doesn't fix csgo colors. You need a space before \x01. Take a look at this. |
|
Do other prints from SourceMod base plugins have this extra space? I would think that it should only be added for CS:GO, if at all since it will cause these specific messages to be offset from the rest of chat. |
|
I think now it won't affect on non-csgo games. |
|
Has this fix been pushed yet? I am still seeing this issue on CS:GO servers. Seems like a fair fix that wont affect other games and would fix it until a better fix comes out. |
I haven't looked though the entire commit history, but judging by the PR still being "Open", no, I would assume that it hasn't been. |
|
I do apologize I did not check the status... Would this be possibly pushed soon? Just wondering if it would be or if there is a fix yet. |
|
Tested on both games, tf2 and cs:go, all works fine. Ready to merge. |
|
@TiBarification did you test that the coloring works on CS:GO? I don't think that the 0xB trick has worked for a couple of years. As @Bara noted, a space is commonly used now instead. |
Yes, it works fine.
Maybe it is really minor |
|
Wow, I totally missed that, only still seeing the 0B (which isn't needed or doing anything, but barely harming anything). Good catch. Thanks. |
Also fixed colors, because it didn't work without
\x01at begin of string.