Move semantics for StringHashMap#589
Merged
KyleSanderson merged 3 commits intoalliedmodders:masterfrom Jul 12, 2018
Merged
Conversation
rsKliPPy
force-pushed
the
stringhashmap-move-semantics
branch
2 times, most recently
from
c72f198 to
379501b
Compare
rsKliPPy
force-pushed
the
stringhashmap-move-semantics
branch
from
379501b to
377d56c
Compare
Member
|
apologies for the delay and thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StringHashMap<T>couldn't previously contain non-copyable objects, likeke::AutoPtr<T>in my case.This PR fixes that and adds new
bool retrieve(const char *, T **)for retrieving a reference to an object within the container in case it's not copyable.