Update sm_map behavior to better reflect FindMap/GetMapDisplayName results#588
Conversation
Increase map name buffer sizes to PLATFORM_MAX_PATH
|
Looks okay to me. My only hesitation is adding a new translation phrase. We've not had any new ones since switching to a rolling release model, and I'm not sure that we have a great way at the moment to ask for updated phrases. Regardless, I suppose an accurate English phrase is better than a incorrect localized one here, so not a huge deal as-is. |
|
Any concerns with the actual language of the phrase? |
|
Nope. |
|
Do any further changes need to be made to this? |
|
It's just the translation phrase that has a hang-up as we haven't added one to my knowledge since switching to the rolling model (and atleast a year prior to that, iirc). If these were split into two separate PRs, only one would be pending. |
|
I can pull out the changes to nominations.sp and its i18n, then, but basically the issue is that there's no good way set up for telling people 'hey we need translations for this new thing'? What was the old setup, again? |
|
Pulled out the nominations commit pending the discussion on how to get translations done. |
FlaminSarge
changed the title
|
Sorry, I thought I pulled this two days ago. Thanks FS. |
3 participants
sm_map now makes use of GetMapDisplayName in the same way that sm_setnextmap did in #354
sm_map and its menu now use PLATFORM_MAX_PATH for map name buffer size instead of 64
nominations has a new message for when a map is found, but not available in the nominations pool (to differentiate it from the map not being found at all)sm_setnextmap now uses ShowActivity2