Add alternative methods for commandfilters#478
Add alternative methods for commandfilters#478LivingInPortal wants to merge 1 commit intoalliedmodders:masterfrom
Conversation
|
I like the idea. However, your implementation for it seems really over engineered. I believe we can just pass the admin paramater... Something like the following (untested) may work? |
|
The problem there is that you don't know if core is new enough or not to pass a valid value for that. If you were to compile on SM with this, but at runtime have an older version, the param would have garbage. The requirement of the new native avoids that situation. |
|
True, that case can fall under FeatureType_Capability (which is not present in my snippet). |
|
Closing this one (sorry @LivingInPortal - thank you very much for the contribution) in favour for the child PR. There's no guarantee it will be merged but it's the same functionality ultimately and it's what we both want out of this 😄 |
I have a need to know who triggered the commandfilters so created this pull request.
This should not affect the origin API.