Conversation
dvander
added a commit
that referenced
this pull request
Jun 22, 2014
Introduce 4-token lookahead buffer.
dvander
added a commit
that referenced
this pull request
Nov 4, 2015
Hide symbol::addr access behind a getter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The grammar for the Transitional Syntax requires four tokens of lookahead. For example, when encountering the
publickeyword for a method definition, we need to look for<symbol>,(,), and=to determine whether it's bind-to-existing-native syntax. If it's not, we have to rewind back to the(to look for a constructor, or even all the way back to the symbol to check for a type expression.This patch refactors the lexer to keep two buffers: one for preprocessor lexing, and one for normal lexing. Each buffer can remember four tokens.