Conversation
Member
|
🐑 it! |
psychonic
added a commit
that referenced
this pull request
Jun 20, 2014
Enable C++11 on posix (r=dvander).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since building with msvc12 on Windows now, support for C++11 is already enabled there implicitly.
This set of commits enables it for Linux and Mac. I tested with the Clang 3.4 on our Linux build VM.
-Wno-deprecated-register is added since the "register" keyword used in some of the SDKs is deprecated in C++11.
-Wno-implicit-exception-spec-mismatch is added for our delete and delete[] overrides.
Without it, when building with C++ enabled, the warning is thrown (at least on linux with gcc 4.7 C++ headers) due to those functions being defined in the headers with _GLIBCXX_USE_NOEXCEPT. I don't know how portable that is - if we can just add it to our versions if linux is defined so I silenced the warning/error. We can always adjust things later if necessary.