Skip to content

Improved compile.sh spacing (and changed nothing else).#31

Closed
WildCard65 wants to merge 6 commits intoalliedmodders:masterfrom
WildCard65:master
Closed

Improved compile.sh spacing (and changed nothing else).#31
WildCard65 wants to merge 6 commits intoalliedmodders:masterfrom
WildCard65:master

Conversation

@WildCard65
Copy link
Contributor

@50Wliu spacing improvements I re-added to this PR to make it compat with the revert of @50Wliu reverted commit.

@WildCard65 WildCard65 changed the title Fixed a @50Wliu Fixed a @50Wliu derp in bash compile script Jun 7, 2014
@winstliu
Copy link
Contributor

winstliu commented Jun 7, 2014

This is really what I get for testing it once, then adding some more changes <.<

@Impact123
Copy link
Contributor

Well, you're supposed to review your pull request before you send it 😆

@WildCard65
Copy link
Contributor Author

Ya and I tested my change (which is just simple) and it works.

@winstliu
Copy link
Contributor

winstliu commented Jun 7, 2014

Something I forgot to add in my PR:
Add -t10 to the read command. This gives a timeout of 10 seconds, which should be enough to see if there were any errors.

@WildCard65
Copy link
Contributor Author

Just going to leave this open as I like the improvements in readability of @50Wliu changes

@WildCard65 WildCard65 changed the title Fixed a @50Wliu derp in bash compile script Improved compile.sh spacing (and changed nothing else). Jun 9, 2014
@WildCard65
Copy link
Contributor Author

Updated changes to include a request by @50Wliu which is to exit if spcomp fails to compile a file.
And I tested it and it works, the commit WildCard65@6ffcd2ecb fixes the script cause of a derp on my part, this commit actually is working version.

@winstliu
Copy link
Contributor

winstliu commented Jun 9, 2014

There's some tabbing problems (line 10, lines 22-28).

@Impact123
Copy link
Contributor

The file still has mixed tabs and spaces all over the place.
I recommend you to use an editor which can show you the tabs/spaces.

@WildCard65
Copy link
Contributor Author

That is because most of it had spaces to begin with.

@WildCard65
Copy link
Contributor Author

Going to close this and continue on a new branch

@WildCard65 WildCard65 closed this Jun 14, 2014
dvander added a commit that referenced this pull request Nov 4, 2015
Remove support for custom destructors.
dvander added a commit that referenced this pull request Nov 4, 2015
Fix the nullable keyword not being inherited after #31.
This was referenced Aug 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants