Fix rare crash with logs#2161
Merged
peace-maker merged 3 commits intoalliedmodders:masterfrom May 24, 2024
Merged
Conversation
asherkin
requested changes
May 19, 2024
psychonic
approved these changes
May 19, 2024
asherkin
approved these changes
May 19, 2024
Member
asherkin
left a comment
asherkin
left a comment
There was a problem hiding this comment.
LGTM - I think checking Add/RemoveLogHook was sane too, but is indeed unlikely to be necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue mentioned to Asherkin or Psychonic.
Long story short, if a metamod plugin happens to be detouring some game functions that SM unfortunately calls while initialising, and decides to have the console print something. It will trigger
FileFileNatives::LogPrint, however by that pointg_pLogHookhas not yet been initialised, it's still a nullptr. This of course ends up with a nullpointer crash.Let's
add a member property that tracks whether or not we've been initialised.nullcheckg_pLogHook