Fix IsClientSourceTV in L4D2#2143
Merged
asherkin merged 1 commit intoalliedmodders:masterfrom Apr 28, 2024
adriansmares:fix/l4d2-check
Merged
Fix IsClientSourceTV in L4D2#2143asherkin merged 1 commit intoalliedmodders:masterfrom adriansmares:fix/l4d2-check
asherkin merged 1 commit intoalliedmodders:masterfrom
adriansmares:fix/l4d2-check
Conversation
asherkin
approved these changes
Apr 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References 8a10f4b
References 90ca9d7
This PR fixes
IsClientSourceTVin L4D2 when a customtv_nameis used. Specifically a nonSourceTVtv_namewas incorrectly resulting in the bot not being considered the SourceTV bot.The first commit makes this specific distinction for L4D2 - that the bot is spawned as
SourceTVeven iftv_namehas a different value. The second commit makes L4D2 also compare the bot name withtv_nameeven though this is not applicable.Credit for finding the cause of this issue goes to @asherkin . Tested with SourceTV Support and hide_sourcetv (which seemed to be broken with a custom
tv_name, but the problem was in SM).