Throw an error when attempting to remove worldspawn in RemoveEntity/RemoveEdict#2104
Merged
peace-maker merged 2 commits intoalliedmodders:masterfrom Feb 20, 2024
CookieCat45:master
Merged
Throw an error when attempting to remove worldspawn in RemoveEntity/RemoveEdict#2104peace-maker merged 2 commits intoalliedmodders:masterfrom CookieCat45:master
peace-maker merged 2 commits intoalliedmodders:masterfrom
CookieCat45:master
Conversation
peace-maker
approved these changes
Feb 15, 2024
Member
peace-maker
left a comment
peace-maker
left a comment
There was a problem hiding this comment.
Thank you, an error message is indeed easier to debug than a crash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's probably common knowledge at this point that calling
RemoveEntityon the worldspawn will instantly crash the server. Since it can be agreed that there is no real reason to ever do this, I've changed it so that it throws an error instead. This way, if a plugin ends up accidentally removing the worldspawn, it will be much easier for the plugin author to fix the issue.