make RenameFile() on Windows also replace the file#2060
Merged
psychonic merged 2 commits intoalliedmodders:masterfrom May 5, 2024
Merged
make RenameFile() on Windows also replace the file#2060psychonic merged 2 commits intoalliedmodders:masterfrom
psychonic merged 2 commits intoalliedmodders:masterfrom
Conversation
Contributor
Author
|
accidentally made the pr on this repo instead my fork when trying to test github actions building the binary for testing. if the binary works correctly though then I'll keep the pr open edit: it sucks that actions don't cache generated artifacts. that would be very useful if they did. wink wink nudge nudge |
BoomShotKapow
added a commit
to BoomShotKapow/shavit-myreplay
that referenced
this pull request
Oct 9, 2023
psychonic
requested changes
May 5, 2024
Member
psychonic
left a comment
psychonic
left a comment
There was a problem hiding this comment.
Looking at the available flags, I think we should probably add MOVEFILE_COPY_ALLOWED as well
Contributor
Author
Good idea. Added it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RenameFileon linux usesrename()which will replace the destination file if it exists.MoveFileAdoesn't replace so this is swapping it withMoveFileExA+MOVEFILE_REPLACE_EXISTINGwhich will replace the destination.