[1.11] update maxplayers define for 07-25-23 tf2 update#2025
Closed
sapphonie wants to merge 2 commits intoalliedmodders:1.11-devfrom
Closed
[1.11] update maxplayers define for 07-25-23 tf2 update#2025sapphonie wants to merge 2 commits intoalliedmodders:1.11-devfrom
sapphonie wants to merge 2 commits intoalliedmodders:1.11-devfrom
Conversation
This should really be handled per game IMO, but until then, TF2 supports 100 players now. Hooray!
Contributor
Author
|
https://github.com/ValveSoftware/source-sdk-2013/blob/0d8dceea4310fde5706b3ce1c70609d72a38efdf/mp/src/game/client/game_controls/SpectatorGUI.cpp#L229-L242 MAX_PLAYERS == 33 here Same function on TF2: ( result - 1 ) <= 100 implies 101 |
Contributor
Author
|
It should be noted that several base plugins use MAXPLAYERS defines so... not sure how to handle that one, lol |
Member
|
If and when we are ready to backport this from master, we'll just cherry-pick it from there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This should really be handled per game IMO, but until then, TF2 supports 100 players now. Hooray!