Make KeyValues.Rewind traversal-stack clearing optional#1993
Merged
asherkin merged 2 commits intoalliedmodders:masterfrom Apr 17, 2023
Merged
Make KeyValues.Rewind traversal-stack clearing optional#1993asherkin merged 2 commits intoalliedmodders:masterfrom
asherkin merged 2 commits intoalliedmodders:masterfrom
Conversation
asherkin
reviewed
Apr 16, 2023
Member
asherkin
left a comment
There was a problem hiding this comment.
One minor doc comment, then this is good to go I think.
I'm not super familiar with this area either, but what you've implemented is what I expected it to look like at least!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested by asherkin in the discord.
Hopefully implemented properly; not sure if there's other behaviour I'm not factoring in.
Tested with the following code: