Conversation
dvander
approved these changes
Dec 19, 2022
Contributor
|
Can't make it work on CS:S using SM 1.11 |
Member
Author
Thanks for letting me know. In the specific case that I was using it for, I was already expecting it to not display (and it still doesn't, after having fixed the plugin). What I should have done, was also tested the positive case. Since no error was thrown, I had assumed the code was fine. I was missing the SetHudTextParams call. Fixed now. I'm also going to add a check that could have caught this case and thrown an error. |
Contributor
|
With 914e253, it's now working properly on CS:S. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This saves me from having to find/create a test plugin when checking for what games support this, has very low maintenance burden, and just may actually be useful for someone other than me.
"d" was chosen for the prefix over the more intuitive "h" since hint messages use that.