entitylump: Output separator as spaces instead of tabs#1873
Merged
peace-maker merged 1 commit intoalliedmodders:masterfrom Dec 5, 2022
Merged
entitylump: Output separator as spaces instead of tabs#1873peace-maker merged 1 commit intoalliedmodders:masterfrom
peace-maker merged 1 commit intoalliedmodders:masterfrom
Conversation
On NMRiH and possibly other games that use the Maphacks system, entries that are modified using that system are rendered with tab characters stripped out - see CNMRiHMapHackManager::GetEntDataString. That results in there being no separators at all between keys and values, as Maphacks receives the serialized string from Entity Lump Manager. This commit changes the key / value separator character to use spaces instead. This discovery upsets me greatly. Fixes alliedmodders#1833.
peace-maker
approved these changes
Dec 5, 2022
Member
|
Good work! |
Contributor
Author
|
@peace-maker can this also get backported into 1.11? The entity lump code was recently merged there. I can open a new PR for it if that's necessary. |
Member
Yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On NMRiH and possibly other games that use the Maphack system, entries that are modified using that system are rendered with tab characters stripped out - see
CNMRiHMapHackManager::GetEntDataString.That results in there being no separators at all between keys and values, as Maphack receives the serialized string from Entity Lump Manager, which uses tabs as its key / value separator.
This crash only occurs if
GetMapHackManager()->HasEntData()is set to true, so to my understanding it would not crash on removals of entire entities, and it would not crash on maps that do not use Maphack at all.This commit changes the key / value separator character to use spaces instead.
Fixes #1833.