Add CommandIterator.ConVarFlags property#1869
Merged
peace-maker merged 3 commits intomasterfrom Dec 4, 2022
Merged
Conversation
Allow to access the convar flags `FCVAR_*` value from the iterator. The CommandIterator.Flags property should have been called `AdminFlags`, but it's too late to change that now.
No need to lookup the convar again.
asherkin
approved these changes
Dec 1, 2022
Member
asherkin
left a comment
asherkin
left a comment
There was a problem hiding this comment.
Is it worth aliasing Flags as AdminFlags and deprecating the former now?
Member
Author
|
Yes, but deprecation of methodmap properties isn't implemented. alliedmodders/sourcepawn#676 |
Rename it to .AdminFlags now that we have two kinds of flags exposed on the iterator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow to access the convar flags
FCVAR_*value from the iterator using aConVarFlagsproperty.The
CommandIterator.Flagsproperty should have been calledAdminFlags, but it's too late to change that now.This was brought up in #1831.