Return the full list of exts/plugins with "sm exts/plugins"#1862
Merged
asherkin merged 2 commits intoalliedmodders:masterfrom Nov 25, 2022
Merged
Return the full list of exts/plugins with "sm exts/plugins"#1862asherkin merged 2 commits intoalliedmodders:masterfrom
asherkin merged 2 commits intoalliedmodders:masterfrom
Conversation
Member
|
Allegedly? Have you tested this change? |
Contributor
Author
|
I tested on CS:GO with around 90 plugins printed out 10 times which makes it effectively 900 plugins. One possible downside is that if the client has packet loss, they risk not receiving every plugin, but this also happens on current version as well when you do |
Member
|
Sounds good. We can drop the |
Contributor
Author
|
The |
peace-maker
approved these changes
Nov 21, 2022
asherkin
approved these changes
Nov 25, 2022
Member
asherkin
left a comment
asherkin
left a comment
There was a problem hiding this comment.
Wild to see something like this change after all these years.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1611. Allegedly #1071 allows this to work.