Clear gamerules pointer on level shutdown#1755
Merged
peace-maker merged 2 commits intoalliedmodders:masterfrom Apr 22, 2022
Merged
Clear gamerules pointer on level shutdown#1755peace-maker merged 2 commits intoalliedmodders:masterfrom
peace-maker merged 2 commits intoalliedmodders:masterfrom
Conversation
peace-maker
approved these changes
Apr 21, 2022
psychonic
pushed a commit
that referenced
this pull request
Jun 11, 2022
* Clear gamerules pointer on level shutdown * Move LevelShutdown up (cherry picked from commit a877a44)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #1694, this PR fixes an issue where the gamerules pointer would not be cleared on level shutdown, leading to crashes when natives like
TF2_IsHolidayActivetry to access it before it's populated again.