DHooks: Allow setting CBaseEntity* param to NULL #1751#1754
Merged
peace-maker merged 2 commits intomasterfrom Apr 20, 2022
Merged
DHooks: Allow setting CBaseEntity* param to NULL #1751#1754peace-maker merged 2 commits intomasterfrom
peace-maker merged 2 commits intomasterfrom
Conversation
The param had to be a valid entity and wasn't allowed to be set to NULL. Behave similar to SetReturn which maps INVALID_ENT_REFERENCE (or -1) to NULL.
psychonic
approved these changes
Apr 20, 2022
Member
psychonic
left a comment
psychonic
left a comment
There was a problem hiding this comment.
I think this should probably get documented in the include file as well, that -1 is accepted for a NULL entity pointer.
asherkin
approved these changes
Apr 20, 2022
psychonic
approved these changes
Apr 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The param had to be a valid entity and wasn't allowed to be set to NULL. Behave similar to SetReturn which maps INVALID_ENT_REFERENCE (or -1) to NULL.
Fixes #1751