Skip to content

Remove hardcoded a question mark#1699

Merged
asherkin merged 1 commit intoalliedmodders:masterfrom
TheByKotik:remove-hardcoded-a-question-mark
Feb 3, 2022
Merged

Remove hardcoded a question mark#1699
asherkin merged 1 commit intoalliedmodders:masterfrom
TheByKotik:remove-hardcoded-a-question-mark

Conversation

@TheByKotik
Copy link
Contributor

My little arguments:

  1. Hardcoded strings is not a good idea.
  2. In some cases it is really looks amiss (in my language).

Copy link
Member

@peace-maker peace-maker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine. I've seen many How much is the fish?? votes, where the question already included the questionmark.

@asherkin asherkin merged commit f5461df into alliedmodders:master Feb 3, 2022
@TheByKotik TheByKotik deleted the remove-hardcoded-a-question-mark branch February 3, 2022 12:05
psychonic pushed a commit that referenced this pull request Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants