Merged
Conversation
Contributor
Author
* - I didn't realise the size was off by 1 until I already hit submit, but I'm not sure if it should be changed |
Member
|
@asherkin I remember you had reservations about hard coding steam authentication eons ago (which we well moved on from, which was also well before steam|/3). Based on the trajectory I'm OK with this. Fun/base have this at 64 chars right now on a [3][64] array. Long term to avoid the MAXPLAYERS+2 issue I think we want to reserve a 128b rendered value. WDYT? |
asherkin
approved these changes
Feb 15, 2022
Member
asherkin
left a comment
asherkin
left a comment
There was a problem hiding this comment.
👍 32 seems like a good length to me.
Member
|
That said, I think this should be |
asherkin
force-pushed
the
steamid-size-constant
branch
from
90c56dc to
7ab9344
Compare
Member
|
It turns out that Valve actually have this defined in the SDK |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I feel like this is sorely missing since I've had to define it in so many plugins I've written.
The maximum theoretical size of a 'valid' SteamID (according to the valve wiki) is 23 bytes including null
STEAM_255:1:2147483647.The only exception that I know of is
STEAM_ID_STOP_IGNORING_RETVALSwhich is 31* bytes including null.In the interest of keeping that error value meaningful, either: